Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 435293003: Don't activate minimized/bottom home card (Closed)

Created:
6 years, 4 months ago by oshima
Modified:
6 years, 4 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Don't activate minimized/bottom home card Home Card will be minimized when an activity is activated, so don't re-activate home card. There is also no need to activate bottom home card, so activate the centered home card only. BUG=400575 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287691

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M athena/home/home_card_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
6 years, 4 months ago (2014-08-05 06:26:42 UTC) #1
Jun Mukai
lgtm
6 years, 4 months ago (2014-08-05 07:28:23 UTC) #2
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 4 months ago (2014-08-05 15:53:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/435293003/20001
6 years, 4 months ago (2014-08-05 15:54:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 18:11:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 18:27:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42673)
6 years, 4 months ago (2014-08-05 18:27:35 UTC) #7
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 4 months ago (2014-08-05 23:49:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/435293003/20001
6 years, 4 months ago (2014-08-05 23:50:19 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 05:54:50 UTC) #10
Message was sent while issue was closed.
Change committed as 287691

Powered by Google App Engine
This is Rietveld 408576698