Make tests related to undo word deletion platform independent

Make tests related to undo word deletion platform independent

This patch makes the following tests platform independent.
editing/undo/undo-combined-delete-boundary.html
editing/undo/undo-combined-delete.html
editing/undo/undo-delete-boundary.html
editing/undo/undo-delete.html
editing/undo/undo-forward-delete-boundary.html
editing/undo/undo-forward-delete.html

R=ojan, yosin, leviw

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160755

[vanihegde, 2013-10-25 07:52:03]

As of now I have modified only editing/undo/undo-delete.html.
If this change is fine, I will go ahead and modify other tests similarly. 

Please note that, once I introduced the cpp changes as per 
https://codereview.chromium.org/43143003/

I will have to modify
undoTest('mac', 'Range', 4, 0);
undoTest('win', 'Range', 4, 0);
undoTest('unix', 'Range', 4, 0);
undoTest('android', 'Range', 4, 0);

as
undoTest('mac', 'Range', 4, 0);
undoTest('win', 'Caret', 4, 4);
undoTest('unix', 'Caret', 4, 4);
undoTest('android', 'Caret', 4, 4);

in the test case. And ofcourse I need to update expectation.txt

Please have a look. Thanks

[yosin_UTC9, 2013-10-25 08:03:04]

Thanks for quick work!

https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
File LayoutTests/editing/undo/undo-delete.html (right):

https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
LayoutTests/editing/undo/undo-delete.html:14: function undoTest(platform,
selectionType, expectedStartOffset, expectedEndOffset) {
nit: If we have |debug(platform)|, it helps debugging if this test failed.

https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
LayoutTests/editing/undo/undo-delete.html:17: var range =
document.createRange();
nit: seletion.collapse(startNode, startOffset) is easier.
I'm not aware this method recently... :-<

https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
LayoutTests/editing/undo/undo-delete.html:26:
shouldBeEqualToString('selection.type', selectionType);
Since, selection.type isn't standard. So, we should omit this.

https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
LayoutTests/editing/undo/undo-delete.html:27: shouldBe('selection.baseNode',
'startNode');
Could you use {anchor,focus}{Node,Offste}? They are standard API.

https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
LayoutTests/editing/undo/undo-delete.html:39: debug("To test manually, place the
cursor at the end of the word 'Test' and delete it completely character by
character. Do ctrl+z. On Mac, the word 'Test' should be selected. On other
platforms the word 'Test' should not be selected and the cursor should be placed
at the end of the word.");
nit: Could you put this message in HTML? We can see this message when we just
open this file.

I'm usually reduce output of test expectation text by

<div id="container">
<p id="description">...</p>
... manual steps ...
... test sample ...
...
</div>
<div id="console"></div>

if (window.testRunner) 
  document.getElementById('container').outerHTML = '';

[ojan, 2013-10-26 01:34:24]

LGTM with yosin's feedback.

[vanihegde, 2013-10-28 04:27:25]

On 2013/10/25 08:03:04, Yoshifumi Inoue wrote:
> Thanks for quick work!
> 
>
https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
> File LayoutTests/editing/undo/undo-delete.html (right):
> 
>
https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
> LayoutTests/editing/undo/undo-delete.html:14: function undoTest(platform,
> selectionType, expectedStartOffset, expectedEndOffset) {
> nit: If we have |debug(platform)|, it helps debugging if this test failed.
DONE
 
>
https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
> LayoutTests/editing/undo/undo-delete.html:17: var range =
> document.createRange();
> nit: seletion.collapse(startNode, startOffset) is easier.
> I'm not aware this method recently... :-<
DONE

>
https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
> LayoutTests/editing/undo/undo-delete.html:26:
> shouldBeEqualToString('selection.type', selectionType);
> Since, selection.type isn't standard. So, we should omit this.
DONE

>
https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
> LayoutTests/editing/undo/undo-delete.html:27: shouldBe('selection.baseNode',
> 'startNode');
> Could you use {anchor,focus}{Node,Offste}? They are standard API.
DONE

>
https://codereview.chromium.org/43523002/diff/1/LayoutTests/editing/undo/undo...
> LayoutTests/editing/undo/undo-delete.html:39: debug("To test manually, place
the
> cursor at the end of the word 'Test' and delete it completely character by
> character. Do ctrl+z. On Mac, the word 'Test' should be selected. On other
> platforms the word 'Test' should not be selected and the cursor should be
placed
> at the end of the word.");
> nit: Could you put this message in HTML? We can see this message when we just
> open this file.
DONE
 
> I'm usually reduce output of test expectation text by
> 
> <div id="container">
> <p id="description">...</p>
> ... manual steps ...
> ... test sample ...
> ...
> </div>
> <div id="console"></div>
> 
> if (window.testRunner) 
>   document.getElementById('container').outerHTML = '';
I hope I have done this right!

[vanihegde, 2013-10-28 10:07:20]

I have modified all the tests. Please have a look. Thanks.

[ojan, 2013-10-28 21:08:44]

lgtm

[commit-bot: I haz the power, 2013-10-28 21:09:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/43523002/120001

[commit-bot: I haz the power, 2013-10-28 21:59:33]

Change committed as 160755