Speed-up ScreenOrientationListenerTest.

Speed-up ScreenOrientationListenerTest.

A criteria was always timing out instead of stopping when needed.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287338

[mlamouri (slow - plz ping), 2014-08-04 12:30:23]

I've included some changes based on review comments you made on another CL.

PTAL

[Peter Beverloo, 2014-08-04 12:58:19]

lgtm

https://codereview.chromium.org/435193002/diff/20001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java
(right):

https://codereview.chromium.org/435193002/diff/20001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java:58:
OrientationChangeObserverCriteria criteria =
nit: maybe move this after the ThreadUtils.rOUTB call to group the code
together, like it was?

[mlamouri (slow - plz ping), 2014-08-04 14:32:47]

https://codereview.chromium.org/435193002/diff/20001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java
(right):

https://codereview.chromium.org/435193002/diff/20001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java:58:
OrientationChangeObserverCriteria criteria =
On 2014/08/04 12:58:19, Peter Beverloo wrote:
> nit: maybe move this after the ThreadUtils.rOUTB call to group the code
> together, like it was?

This is actually the change making the test faster. By moving this down, we
setup the criteria *after* the lock should have happened which means that the
criteria will likely end with a timeout instead of from a change. By creating
the criteria before the lock is called, we are sure it is setup with the right
orientation value so when we check if there was a change, we are actually able
to detect it.

[mlamouri (slow - plz ping), 2014-08-04 14:32:51]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-08-04 14:34:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/435193002/20001

[commit-bot: I haz the power, 2014-08-04 15:42:12]

Change committed as 287338