Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 435183002: Gallery.app: Bind the target item to the save function. (Closed)

Created:
6 years, 4 months ago by hirono
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery.app: Bind the target item to the save function. Previously the gallery refers the current selected item to save images. But the selection can be out of sync when a user traverses images before saving changes. BUG=400016 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ui/file_manager/gallery/js/slide_mode.js View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 4 months ago (2014-08-04 10:35:04 UTC) #1
yoshiki
lgtm
6 years, 4 months ago (2014-08-04 16:37:03 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-05 00:57:03 UTC) #3
hirono
On 2014/08/04 16:37:03, yoshiki wrote: > lgtm Thanks!
6 years, 4 months ago (2014-08-05 00:57:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/435183002/1
6 years, 4 months ago (2014-08-05 01:00:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 02:12:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 02:36:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/2658)
6 years, 4 months ago (2014-08-05 02:36:31 UTC) #8
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-05 04:02:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/435183002/1
6 years, 4 months ago (2014-08-05 04:03:39 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 04:30:04 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 04:59:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/2678)
6 years, 4 months ago (2014-08-05 04:59:03 UTC) #13
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-05 05:12:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/435183002/1
6 years, 4 months ago (2014-08-05 05:13:23 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 05:39:03 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 08:09:21 UTC) #17
Message was sent while issue was closed.
Change committed as 287491

Powered by Google App Engine
This is Rietveld 408576698