Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 435163002: ui: Move mac gfx tests into gfx_unittests target. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

ui: Move mac gfx tests into gfx_unittests target. This is pretty straightforward, just moving the remaining mac tests from ui_unittests.gyp to gfx_tests.gyp. gfx_unittests now has a TestSuite that setups everything we need to run it. BUG=331829 TEST=ui_unittests, gfx_unittests TBR=ben@chromium.org,danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M ui/gfx/gfx_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ui_unittests.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...
6 years, 4 months ago (2014-08-04 04:16:32 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-04 04:16:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/435163002/1
6 years, 4 months ago (2014-08-04 04:17:25 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 06:04:52 UTC) #4
commit-bot: I haz the power
Change committed as 287300
6 years, 4 months ago (2014-08-04 07:18:50 UTC) #5
Ben Goodger (Google)
6 years, 4 months ago (2014-08-06 18:26:31 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698