Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 435093003: Keep track of the number of skia operations (Closed)

Created:
6 years, 4 months ago by hendrikw
Modified:
6 years, 4 months ago
CC:
reviews_skia.org, vmiura
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Moved SkPictureContentInfo into its own file. It now tracks the number of skia operations (maybe, I'm not 100% sure I'm doing this right yet) and the number of text draws. I also moved some of the gpu logic out of SkPictureRecord and into SkPictureContentInfo, http://code.google.com/p/chromium/issues/detail?id=396908 http://code.google.com/p/chromium/issues/detail?id=397198 http://code.google.com/p/chromium/issues/detail?id=399728 BUG=396908 Committed: https://skia.googlesource.com/skia/+/afdada2eabdef47a59e08c884b2beb1af3f31aa5

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep track of op count for 396908 #

Total comments: 1

Patch Set 3 : Fixed the date in SKPictureContnetInfo.cpp #

Total comments: 6

Patch Set 4 : Fixes for Robert's comments #

Total comments: 1

Patch Set 5 : Fixed a typo in one of the header includes #

Patch Set 6 : Fixed the return type of numOperations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -109 lines) Patch
M gyp/core.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A src/core/SkPictureContentInfo.h View 1 2 3 4 5 1 chunk +54 lines, -0 lines 0 comments Download
A src/core/SkPictureContentInfo.cpp View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download
M src/core/SkPictureData.h View 2 chunks +1 line, -59 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 2 3 4 1 chunk +2 lines, -31 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 4 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
nduca
https://codereview.chromium.org/435093003/diff/1/src/core/SkPictureContentInfo.h File src/core/SkPictureContentInfo.h (right): https://codereview.chromium.org/435093003/diff/1/src/core/SkPictureContentInfo.h#newcode13 src/core/SkPictureContentInfo.h:13: class SkPictureContentInfo { it seems like a SkPictureContentInfo and ...
6 years, 4 months ago (2014-08-02 00:59:30 UTC) #1
nduca
6 years, 4 months ago (2014-08-02 00:59:48 UTC) #2
hendrikw
Hi, please let me know what you think. http://code.google.com/p/chromium/issues/detail?id=396908
6 years, 4 months ago (2014-08-02 01:33:13 UTC) #3
mtklein
As a refactor, this looks great to me. Before we get too far into this ...
6 years, 4 months ago (2014-08-02 14:06:28 UTC) #4
mtklein
On 2014/08/02 00:59:30, nduca wrote: > https://codereview.chromium.org/435093003/diff/1/src/core/SkPictureContentInfo.h > File src/core/SkPictureContentInfo.h (right): > > https://codereview.chromium.org/435093003/diff/1/src/core/SkPictureContentInfo.h#newcode13 > ...
6 years, 4 months ago (2014-08-02 14:09:35 UTC) #5
robertphillips
https://codereview.chromium.org/435093003/diff/40001/gyp/core.gypi File gyp/core.gypi (right): https://codereview.chromium.org/435093003/diff/40001/gyp/core.gypi#newcode132 gyp/core.gypi:132: '<(skia_src_path)/core/SkPicture.cpp', Add .h in here somewhere too? https://codereview.chromium.org/435093003/diff/40001/src/core/SkPictureContentInfo.cpp File ...
6 years, 4 months ago (2014-08-04 14:31:24 UTC) #6
hendrikw
I've fixed the issues that Mike and Robert pointed out, thanks! Can someone verify that ...
6 years, 4 months ago (2014-08-04 19:24:33 UTC) #7
robertphillips
lgtm. To the best of my knowledge addDraw is the correct location for counting the ...
6 years, 4 months ago (2014-08-07 14:18:13 UTC) #8
hendrikw
The CQ bit was checked by hendrikw@chromium.org
6 years, 4 months ago (2014-08-08 16:57:44 UTC) #9
hendrikw
The CQ bit was unchecked by hendrikw@chromium.org
6 years, 4 months ago (2014-08-08 16:57:45 UTC) #10
hendrikw
The CQ bit was checked by hendrikw@chromium.org
6 years, 4 months ago (2014-08-08 17:04:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/hendrikw@chromium.org/435093003/60001
6 years, 4 months ago (2014-08-08 17:05:38 UTC) #12
hendrikw
The CQ bit was unchecked by hendrikw@chromium.org
6 years, 4 months ago (2014-08-08 17:08:23 UTC) #13
hendrikw
The CQ bit was checked by hendrikw@chromium.org
6 years, 4 months ago (2014-08-08 17:23:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/hendrikw@chromium.org/435093003/80001
6 years, 4 months ago (2014-08-08 17:23:50 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-08 17:31:10 UTC) #16
hendrikw
The CQ bit was unchecked by hendrikw@chromium.org
6 years, 4 months ago (2014-08-08 17:32:39 UTC) #17
hendrikw
The CQ bit was checked by hendrikw@chromium.org
6 years, 4 months ago (2014-08-08 17:37:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/hendrikw@chromium.org/435093003/100001
6 years, 4 months ago (2014-08-08 17:38:02 UTC) #19
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 17:44:39 UTC) #20
Message was sent while issue was closed.
Change committed as afdada2eabdef47a59e08c884b2beb1af3f31aa5

Powered by Google App Engine
This is Rietveld 408576698