Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 435043003: Update Pica WPR and replace 'pica' benchmark with 'polymer_load.pica' (Closed)

Created:
6 years, 4 months ago by adamk
Modified:
6 years, 4 months ago
Reviewers:
ykyyip, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update Pica WPR and replace 'pica' benchmark with 'polymer_load.pica' The polymer_load measurement is one we intend to use for measuring other Polymer apps loading (e.g., paper-calculator, Topeka). R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
D tools/perf/benchmarks/pica.py View 1 chunk +0 lines, -24 lines 0 comments Download
M tools/perf/benchmarks/polymer_load.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/pica.json View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/pica_009.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
adamk
6 years, 4 months ago (2014-08-01 20:39:32 UTC) #1
adamk
Hmm, I misidentified what happened here. It appears page_cycler.pica stopped working and pica.pica started. Buildbot ...
6 years, 4 months ago (2014-08-01 20:49:10 UTC) #2
tonyg
On 2014/08/01 20:49:10, adamk wrote: > Hmm, I misidentified what happened here. It appears page_cycler.pica ...
6 years, 4 months ago (2014-08-01 20:53:43 UTC) #3
tonyg
lgtm
6 years, 4 months ago (2014-08-01 20:54:11 UTC) #4
adamk
On 2014/08/01 at 20:53:43, tonyg wrote: > On 2014/08/01 20:49:10, adamk wrote: > > Hmm, ...
6 years, 4 months ago (2014-08-01 21:03:12 UTC) #5
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 4 months ago (2014-08-01 21:03:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/435043003/1
6 years, 4 months ago (2014-08-01 21:04:59 UTC) #7
adamk
6 years, 4 months ago (2014-08-01 22:42:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r287109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698