Fix Chromoting client to choose correct OS-specific key filter.

Fix Chromoting client to choose correct OS-specific key filter.

This CL also moves all platform checks to dedicated functions, to help
keep calling logic more readable.

BUG=396348
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287178

[Wez, 2014-08-01 19:07:08]

PTAL

[Jamie, 2014-08-01 19:16:03]

LGTM, and thanks for the clean-up.

https://codereview.chromium.org/435043002/diff/1/remoting/webapp/remoting.js
File remoting/webapp/remoting.js (right):

https://codereview.chromium.org/435043002/diff/1/remoting/webapp/remoting.js#...
remoting/webapp/remoting.js:554: !remoting.platformIsChromeOS();
ChromeOS doesn't seem to report Linux any more, so we could probably get rid of
the ChromeOS check here, although it doesn't do any harm to leave it.

https://codereview.chromium.org/435043002/diff/1/remoting/webapp/remoting.js#...
remoting/webapp/remoting.js:563: return navigator.userAgent.match(/\bCrOS\b/);
indexOf works fine here too. I suspect we were using different schemes only
because they were written by different people.

[Wez, 2014-08-01 21:43:28]

np :)

https://codereview.chromium.org/435043002/diff/1/remoting/webapp/remoting.js
File remoting/webapp/remoting.js (right):

https://codereview.chromium.org/435043002/diff/1/remoting/webapp/remoting.js#...
remoting/webapp/remoting.js:554: !remoting.platformIsChromeOS();
On 2014/08/01 19:16:03, Jamie wrote:
> ChromeOS doesn't seem to report Linux any more, so we could probably get rid
of
> the ChromeOS check here, although it doesn't do any harm to leave it.

navigator.platform still reports Linux on my Chromebox - perhaps you're thinking
of navigator.userAgent?

https://codereview.chromium.org/435043002/diff/1/remoting/webapp/remoting.js#...
remoting/webapp/remoting.js:563: return navigator.userAgent.match(/\bCrOS\b/);
On 2014/08/01 19:16:03, Jamie wrote:
> indexOf works fine here too. I suspect we were using different schemes only
> because they were written by different people.

This isn't quite the same; /\bCrOS\b/ will match "CrOS" but not "iLikeCrOS" nor
"CrOSisAwesome" - arguably we should use this approach for the others as well.

[Wez, 2014-08-01 21:43:31]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-08-01 21:45:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/435043002/20001

[commit-bot: I haz the power, 2014-08-02 07:46:07]

Change committed as 287178