Issue 435024: Adds back the ability to filter cookies by origin in the cookies options view...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 435024: Adds back the ability to filter cookies by origin in the cookies options view... (Closed)

Created:
11 years, 1 month ago by ian fette

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds back the ability to filter cookies by origin in the cookies options view. BUG=27657 TEST=Typing "google" in the search field pulls up origins containing "google" in their name Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33069

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -20 lines)			Patch
M	chrome/browser/cookies_tree_model.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.cc	View	1 2 3	4 chunks	+22 lines, -7 lines	0 comments	Download
M	chrome/browser/views/options/cookies_view.h	View	1	4 chunks	+24 lines, -2 lines	0 comments	Download
M	chrome/browser/views/options/cookies_view.cc	View	1	7 chunks	+59 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ian fette

Ben, can I get a review? Note that if you want to try this out, ...

11 years, 1 month ago (2009-11-24 23:28:56 UTC) #1

Ben Goodger (Google)

LGTM http://codereview.chromium.org/435024/diff/2001/2004 File chrome/browser/cookies_tree_model.cc (right): http://codereview.chromium.org/435024/diff/2001/2004#newcode291 chrome/browser/cookies_tree_model.cc:291: for (int i = num_children - 1; i ...

11 years, 1 month ago (2009-11-24 23:34:55 UTC) #2

ian fette

11 years, 1 month ago (2009-11-25 00:20:40 UTC) #3

Thanks for the review.

http://codereview.chromium.org/435024/diff/2001/2004
File chrome/browser/cookies_tree_model.cc (right):

http://codereview.chromium.org/435024/diff/2001/2004#newcode291
chrome/browser/cookies_tree_model.cc:291: for (int i = num_children - 1; i >= 0;
--i) {
On 2009/11/24 23:34:55, Ben Goodger wrote:
> nit: no braces.

Done.

Expand Messages | Collapse Messages