Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: net/url_request/url_request_unittest.cc

Issue 435017: The FTPDirectoryListing test has been failing in a couple of runs. Marking it... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_unittest.h" 5 #include "net/url_request/url_request_unittest.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 8
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include <windows.h> 10 #include <windows.h>
(...skipping 1892 matching lines...) Expand 10 before | Expand all | Expand 10 after
1903 static void TearDownTestCase() { 1903 static void TearDownTestCase() {
1904 server_ = NULL; 1904 server_ = NULL;
1905 } 1905 }
1906 1906
1907 static scoped_refptr<FTPTestServer> server_; 1907 static scoped_refptr<FTPTestServer> server_;
1908 }; 1908 };
1909 1909
1910 // static 1910 // static
1911 scoped_refptr<FTPTestServer> URLRequestTestFTP::server_; 1911 scoped_refptr<FTPTestServer> URLRequestTestFTP::server_;
1912 1912
1913 TEST_F(URLRequestTestFTP, FTPDirectoryListing) { 1913 // Flaky, see http://crbug.com/25045.
1914 TEST_F(URLRequestTestFTP, FLAKY_FTPDirectoryListing) {
1914 ASSERT_TRUE(NULL != server_.get()); 1915 ASSERT_TRUE(NULL != server_.get());
1915 TestDelegate d; 1916 TestDelegate d;
1916 { 1917 {
1917 TestURLRequest r(server_->TestServerPage("/"), &d); 1918 TestURLRequest r(server_->TestServerPage("/"), &d);
1918 r.Start(); 1919 r.Start();
1919 EXPECT_TRUE(r.is_pending()); 1920 EXPECT_TRUE(r.is_pending());
1920 1921
1921 MessageLoop::current()->Run(); 1922 MessageLoop::current()->Run();
1922 1923
1923 EXPECT_FALSE(r.is_pending()); 1924 EXPECT_FALSE(r.is_pending());
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
2220 ASSERT_TRUE(NULL != server_.get()); 2221 ASSERT_TRUE(NULL != server_.get());
2221 TestDelegate d; 2222 TestDelegate d;
2222 TestURLRequest 2223 TestURLRequest
2223 req(server_->TestServerPage("echoheaderoverride?Accept-Charset"), &d); 2224 req(server_->TestServerPage("echoheaderoverride?Accept-Charset"), &d);
2224 req.set_context(new URLRequestTestContext()); 2225 req.set_context(new URLRequestTestContext());
2225 req.SetExtraRequestHeaders("Accept-Charset: koi-8r"); 2226 req.SetExtraRequestHeaders("Accept-Charset: koi-8r");
2226 req.Start(); 2227 req.Start();
2227 MessageLoop::current()->Run(); 2228 MessageLoop::current()->Run();
2228 EXPECT_EQ(std::string("koi-8r"), d.data_received()); 2229 EXPECT_EQ(std::string("koi-8r"), d.data_received());
2229 } 2230 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698