Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: chrome/browser/jsmessage_box_client.h

Issue 435014: Merge 32889 - Fix crash when an extension popup shows a JS alert. Showing the... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/249/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/jsmessage_box_client.h
===================================================================
--- chrome/browser/jsmessage_box_client.h (revision 32899)
+++ chrome/browser/jsmessage_box_client.h (working copy)
@@ -15,6 +15,7 @@
#include "app/gfx/native_widget_types.h"
+class ExtensionHost;
class GURL;
class Profile;
class TabContents;
@@ -41,10 +42,12 @@
// Indicates whether additional message boxes should be suppressed.
virtual void SetSuppressMessageBoxes(bool suppress_message_boxes) = 0;
- // Returns the TabContents associated with this message box -- in practice,
- // the TabContents implementing this interface -- or NULL if it has no
- // TabContents (e.g., it's an ExtensionHost).
+ // Returns the TabContents or ExtensionHost associated with this message
+ // box -- in practice, the object implementing this interface. Exactly one of
+ // these must be non-NULL; behavior is undefined (read: it'll probably crash)
+ // if that is not the case.
virtual TabContents* AsTabContents() = 0;
+ virtual ExtensionHost* AsExtensionHost() = 0;
};
#endif // CHROME_BROWSER_JSMESSAGE_BOX_CLIENT_H_
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698