Issue 435013002: Add minidump_extensions.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 435013002: Add minidump_extensions.h (Closed)

Created:
6 years, 4 months ago by Mark Mentovai

Modified:
6 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Add minidump_extensions.h, which defines Crashpad/Breakpad extensions to the standard minidump format defined in dbghelp.h. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5ba343ccf1cc

Patch Set 2 : Remove MinidumpExceptionCodeMac #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+388 lines, -6 lines)			Patch
M	compat/compat.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	compat/non_mac/mach/mach.h	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
M	compat/non_win/dbghelp.h	View	1	1 chunk	+5 lines, -6 lines	0 comments	Download
M	minidump/minidump.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	minidump/minidump_extensions.h	View	1	1 chunk	+340 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

LGTM https://codereview.chromium.org/435013002/diff/1/minidump/minidump_extensions.h File minidump/minidump_extensions.h (right): https://codereview.chromium.org/435013002/diff/1/minidump/minidump_extensions.h#newcode202 minidump/minidump_extensions.h:202: kMinidumpExceptionCodeMacBadAccess = 1, // EXC_BAD_ACCESS I'm surprised you're ...

6 years, 4 months ago (2014-08-01 17:48:24 UTC) #2

Mark Mentovai

You’re totally right, that enum didn’t belong at all. How’s this?

6 years, 4 months ago (2014-08-01 18:22:11 UTC) #3

Mark Mentovai

6 years, 4 months ago (2014-08-01 18:37:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as 5ba343ccf1cc (presubmit successful).

Expand Messages | Collapse Messages

Issue 435013002: Add minidump_extensions.h (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove MinidumpExceptionCodeMac #

Messages