Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 434993002: Sync OmniboxEventProto (Closed)

Created:
6 years, 4 months ago by Mark P
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Sync OmniboxEventProto to reflect recently-submitted cr/72364534 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287141

Patch Set 1 #

Total comments: 2

Patch Set 2 : capitalization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/metrics/proto/omnibox_event.proto View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark P
Please take a look, thanks.
6 years, 4 months ago (2014-08-01 16:20:05 UTC) #1
Ilya Sherman
LGTM https://codereview.chromium.org/434993002/diff/1/components/metrics/proto/omnibox_event.proto File components/metrics/proto/omnibox_event.proto (right): https://codereview.chromium.org/434993002/diff/1/components/metrics/proto/omnibox_event.proto#newcode165 components/metrics/proto/omnibox_event.proto:165: // a suggestion powered by a chrome content ...
6 years, 4 months ago (2014-08-01 17:37:47 UTC) #2
Mark P
https://codereview.chromium.org/434993002/diff/1/components/metrics/proto/omnibox_event.proto File components/metrics/proto/omnibox_event.proto (right): https://codereview.chromium.org/434993002/diff/1/components/metrics/proto/omnibox_event.proto#newcode165 components/metrics/proto/omnibox_event.proto:165: // a suggestion powered by a chrome content provider. ...
6 years, 4 months ago (2014-08-01 18:00:47 UTC) #3
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 4 months ago (2014-08-01 18:00:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/434993002/20001
6 years, 4 months ago (2014-08-01 18:01:43 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 01:19:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 287141

Powered by Google App Engine
This is Rietveld 408576698