Issue 434923002: [arm] Unify instruction selector for Word32Neg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434923002: [arm] Unify instruction selector for Word32Neg. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
titzer

CC:
v8-dev, Michael Starzinger

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[arm] Unify instruction selector for Word32Neg. Previously code generation for Word32Neg (implemented as Word32Xor with -1) was somewhat adhoc and not complete. Now it's uniform and supports the full range of operand2's. TEST=cctest/test-instruction-selector-arm,cctest/test-run-machops R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22789

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -24 lines)			Patch
	M	src/compiler/arm/instruction-selector-arm.cc	View		4 chunks	+34 lines, -24 lines	1 comment	Download
	M	test/cctest/compiler/test-instruction-selector-arm.cc	View		2 chunks	+79 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm, but man, we need to start documenting what those match subroutines do. https://codereview.chromium.org/434923002/diff/1/src/compiler/arm/instruction-selector-arm.cc File ...

6 years, 4 months ago (2014-08-01 11:12:33 UTC) #3

Benedikt Meurer

6 years, 4 months ago (2014-08-01 11:14:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22789 (tree was closed).

Expand Messages | Collapse Messages