Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 434883002: Remove observatory symlink from the repository - they have unforseen issues when copying around stu… (Closed)

Created:
6 years, 4 months ago by ricow1
Modified:
6 years, 4 months ago
Reviewers:
koda, Cutch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove observatory symlink from the repository - they have unforseen issues when copying around stuff for testing. Long storry short: for testing the ability to do pub get and pub build we copy in the packages and test them if they have a pubspec yaml file. If you copy a symlink, like the one added in r38788, without -L to cp you will just get the relative symlink copied in, which will, of course, not work. I generally think it is a bad idea to add symlinks to the repo, we have had enough issues with the ones for packages/pub Instead, to keep the testing, add the runtime/bin/vmservice to the location of where we look for packages R=koda@google.com Committed: https://code.google.com/p/dart/source/detail?r=38983

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
D pkg/observatory View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/pkgbuild.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
6 years, 4 months ago (2014-08-01 08:21:08 UTC) #1
ricow1
On 2014/08/01 08:21:08, ricow1 wrote: As far as I can see there are still no ...
6 years, 4 months ago (2014-08-01 08:21:47 UTC) #2
koda
On 2014/08/01 08:21:47, ricow1 wrote: > On 2014/08/01 08:21:08, ricow1 wrote: > > As far ...
6 years, 4 months ago (2014-08-06 16:21:43 UTC) #3
koda
lgtm
6 years, 4 months ago (2014-08-06 16:43:53 UTC) #4
ricow1
Committed patchset #2 manually as r38983 (presubmit successful).
6 years, 4 months ago (2014-08-07 12:59:41 UTC) #5
koda
6 years, 4 months ago (2014-08-07 14:02:33 UTC) #6
Message was sent while issue was closed.
On 2014/08/07 12:59:41, ricow1 wrote:
> Committed patchset #2 manually as r38983 (presubmit successful).

The pub build bot still doesn't run the test in
runtime/bin/vmservice/client/test.

Powered by Google App Engine
This is Rietveld 408576698