Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 434753002: Use leaky singleton traits for TtsPlatformImplAndroid. (Closed)

Created:
6 years, 4 months ago by dmazzoni
Modified:
6 years, 4 months ago
Reviewers:
David Tseng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use leaky singleton traits for TtsPlatformImplAndroid. See bug for details - similar issue as http://crbug.com/122026 BUG=368018 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/speech/tts_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
dmazzoni
6 years, 4 months ago (2014-07-31 21:34:06 UTC) #1
dmazzoni
Ping
6 years, 4 months ago (2014-08-10 21:50:14 UTC) #2
dmazzoni
Ping
6 years, 4 months ago (2014-08-19 17:28:33 UTC) #3
David Tseng
lgtm
6 years, 4 months ago (2014-08-19 17:51:43 UTC) #4
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-08-19 18:34:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/434753002/1
6 years, 4 months ago (2014-08-19 18:34:59 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 19:35:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 20:50:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/7109)
6 years, 4 months ago (2014-08-19 20:50:40 UTC) #9
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-08-19 21:22:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/434753002/1
6 years, 4 months ago (2014-08-19 21:23:07 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 22:28:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (1) as 290678

Powered by Google App Engine
This is Rietveld 408576698