Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 434733003: Added function to get list of networks with prefetched passwords. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Added function to get list of networks with prefetched passwords. Added function that allows javascript apps using gcdPrivate to get a list of networks with prefetched passwords. Rebase of https://codereview.chromium.org/427123002 BUG=383167 TBR=asargent@chromium.org,noamsml@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287049

Patch Set 1 #

Patch Set 2 : Thu 07/31/2014 14:34:51.93 #

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-07-31 21:09:50 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-07-31 21:10:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/434733003/1
6 years, 4 months ago (2014-07-31 21:13:25 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-07-31 21:37:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/434733003/20001
6 years, 4 months ago (2014-07-31 21:39:58 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 03:22:23 UTC) #6
commit-bot: I haz the power
Change committed as 287049
6 years, 4 months ago (2014-08-01 18:24:15 UTC) #7
Noam Samuel
lgtm
6 years, 4 months ago (2014-08-01 18:29:18 UTC) #8
erikchen
6 years, 4 months ago (2014-08-01 21:28:41 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/433703003/ by erikchen@chromium.org.

The reason for reverting is: breaks win7 browser tests.
GcdPrivateAPITest.WifiPasswords

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28....

Powered by Google App Engine
This is Rietveld 408576698