Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 434713002: cc: Fix tile manager queues perftests to use number of layers. (Closed)

Created:
6 years, 4 months ago by vmpstr
Modified:
6 years, 4 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Fix tile manager queues perftests to use number of layers. I made a bit of a blunder when writing the tile manager queues perftests and made them use a variable number of tilings, instead of layers. The important thing for us to test here is how the system behaves with multiple layers. Multiple tilings case is tested at the tiling level iterator level. This patch fixes up all of this. NOTE TO PERF SHERIFFS ===================== Please disregard any performance changes in the tile manager perftests as a result of this patch. This changes fundamentally what the perftests are measuring. R=reveman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287104

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -93 lines) Patch
M cc/resources/tile_manager_perftest.cc View 1 5 chunks +76 lines, -93 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
vmpstr
PTAL. Here are the results: $ ./out/Release/cc_perftests --single-process-tests --gtest_filter="TileManager*Queue*" Note: Google Test filter = TileManager*Queue* ...
6 years, 4 months ago (2014-07-31 18:59:07 UTC) #1
reveman
lgtm with nit https://codereview.chromium.org/434713002/diff/1/cc/resources/tile_manager_perftest.cc File cc/resources/tile_manager_perftest.cc (right): https://codereview.chromium.org/434713002/diff/1/cc/resources/tile_manager_perftest.cc#newcode442 cc/resources/tile_manager_perftest.cc:442: RunRasterQueueConstructTest("2", 2); nit: maybe include the ...
6 years, 4 months ago (2014-07-31 19:07:37 UTC) #2
vmpstr
https://codereview.chromium.org/434713002/diff/1/cc/resources/tile_manager_perftest.cc File cc/resources/tile_manager_perftest.cc (right): https://codereview.chromium.org/434713002/diff/1/cc/resources/tile_manager_perftest.cc#newcode442 cc/resources/tile_manager_perftest.cc:442: RunRasterQueueConstructTest("2", 2); On 2014/07/31 19:07:37, reveman wrote: > nit: ...
6 years, 4 months ago (2014-07-31 20:11:25 UTC) #3
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 4 months ago (2014-07-31 20:11:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/434713002/20001
6 years, 4 months ago (2014-07-31 20:15:00 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 00:22:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 13:05:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/2370)
6 years, 4 months ago (2014-08-01 13:05:56 UTC) #8
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 4 months ago (2014-08-01 16:10:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/434713002/20001
6 years, 4 months ago (2014-08-01 16:14:48 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 22:18:07 UTC) #11
Message was sent while issue was closed.
Change committed as 287104

Powered by Google App Engine
This is Rietveld 408576698