content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java - Issue 434693002: Re-enable ScreenOrientationListenerTest.java and run locking on UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java

Issue 434693002: Re-enable ScreenOrientationListenerTest.java and run locking on UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java b/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java

index 7e809c0e27578f5fdbf9ebe9cdd67fe464869d66..4cd67865a4dea8d0546e81dccba009eb8867c70e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java

@@ -179,15 +179,6 @@ public class ScreenOrientationListener {

}

/**

- * Creates a ScreenOrientationConfigurationListener backend regardless of

- * the current SDK.

- */

- @VisibleForTesting

- void injectConfigurationListenerBackendForTest() {

- mBackend = new ScreenOrientationConfigurationListener();

- }

- /**

* Add |observer| in the ScreenOrientationListener observer list and

* immediately call |onScreenOrientationChanged| on it with the current

* orientation value.

« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java » ('j') | no next file with comments »