Issue 434673002: Add new files to the GN build after r22709.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434673002: Add new files to the GN build after r22709. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger

Modified:
6 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add new files to the GN build after r22709. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22768

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -1 line)			Patch
	M	BUILD.gn	View	1	5 chunks	+105 lines, -0 lines	0 comments	Download
	M	tools/gyp/v8.gyp	View	1	3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Two files appear to be missing: common-operator.h opcodes.h and one has a typo (see below). ...

6 years, 4 months ago (2014-07-31 15:24:50 UTC) #2

Michael Starzinger

Comments addressed, also for the GYP file. Thanks. Landing. https://codereview.chromium.org/434673002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/434673002/diff/1/BUILD.gn#newcode548 BUILD.gn:548: ...

6 years, 4 months ago (2014-07-31 15:31:28 UTC) #3

Michael Starzinger

6 years, 4 months ago (2014-07-31 15:36:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22768 (tree was closed).

Expand Messages | Collapse Messages

Issue 434673002: Add new files to the GN build after r22709. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Messages