Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 43463005: onCharsToGlyphs to handle non-bmp on Mac. (Closed)

Created:
7 years, 1 month ago by bungeman-skia
Modified:
7 years, 1 month ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

onCharsToGlyphs to handle non-bmp on Mac. CTFontGetGlyphsForCharacters is a strange API for non-bmp code points. R=caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=11965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -33 lines) Patch
M src/ports/SkFontHost_mac.cpp View 2 chunks +63 lines, -30 lines 0 comments Download
M tests/FontHostTest.cpp View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
7 years, 1 month ago (2013-10-25 16:52:49 UTC) #1
caryclark
lgtm
7 years, 1 month ago (2013-10-25 16:58:10 UTC) #2
bungeman-skia
7 years, 1 month ago (2013-10-25 17:49:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r11965 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698