Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 43463004: Add target for building Chromium tests for WebRTC. (Closed)

Created:
7 years, 1 month ago by kjellander_chromium
Modified:
7 years, 1 month ago
Reviewers:
navabi1, navabi
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, frankf, cjhopman, bulach
Visibility:
Public.

Description

Add target for building Chromium tests for WebRTC. WebRTC is running the content_browsertests test for ToT WebRTC revisions to track regressions on an early stage. In order to save compile time and build artifacts, we want to build only what's needed (i.e. not the All target). In https://codereview.chromium.org/27622005/ an attempt was made to make content_browsertests_apk to be enough of target to build (that CL made it also build android_tools). Since that approach was having bad sideffects, this helper target should give us everything needed for our build. NOTRY=True TEST=local compile, verifying the apk and host_forwarder is built. BUG=305749 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M build/all_android.gyp View 2 chunks +21 lines, -1 line 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
kjellander_chromium
navabi@: review. Adding frankf@, cjhopman@ and bulach@ as CC just FYI since they were involved ...
7 years, 1 month ago (2013-10-25 13:41:41 UTC) #1
navabi
lgtm
7 years, 1 month ago (2013-10-29 21:04:13 UTC) #2
navabi
On 2013/10/29 21:04:13, navabi wrote: > lgtm Best to let someone that analyzed why just ...
7 years, 1 month ago (2013-10-29 21:05:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/43463004/1
7 years, 1 month ago (2013-11-04 09:14:52 UTC) #4
kjellander_chromium
On 2013/10/29 21:05:30, navabi wrote: > On 2013/10/29 21:04:13, navabi wrote: > > lgtm > ...
7 years, 1 month ago (2013-11-04 09:19:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34199
7 years, 1 month ago (2013-11-04 09:31:57 UTC) #6
kjellander_chromium
Armand, can you lgtm with your navabi@chromium.org account? I don't think your google.com account is ...
7 years, 1 month ago (2013-11-04 09:37:59 UTC) #7
navabi1
On 2013/11/04 09:37:59, Henrik Kjellander wrote: > Armand, can you lgtm with your mailto:navabi@chromium.org account? ...
7 years, 1 month ago (2013-11-04 22:08:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/43463004/1
7 years, 1 month ago (2013-11-05 08:06:04 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97846
7 years, 1 month ago (2013-11-05 12:03:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/43463004/1
7 years, 1 month ago (2013-11-05 12:09:09 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 13:34:17 UTC) #12
Message was sent while issue was closed.
Change committed as 232956

Powered by Google App Engine
This is Rietveld 408576698