Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 434623002: Remove ALL font fallback logic from Skia. (Closed)

Created:
6 years, 4 months ago by djsollen
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove ALL font fallback logic from Skia. Committed: https://skia.googlesource.com/skia/+/1b27704eba15be4e9d1997faac42038493a30be5

Patch Set 1 #

Patch Set 2 : fix win font host #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -651 lines) Patch
D gm/androidfallback.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +0 lines, -4 lines 0 comments Download
M include/core/SkPaintOptionsAndroid.h View 3 chunks +1 line, -11 lines 0 comments Download
M include/ports/SkTypeface_android.h View 1 chunk +0 lines, -34 lines 0 comments Download
M src/core/SkGlyph.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkGlyphCache.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkPaintOptionsAndroid.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkScalerContext.h View 4 chunks +6 lines, -30 lines 0 comments Download
M src/core/SkScalerContext.cpp View 5 chunks +4 lines, -166 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +0 lines, -126 lines 0 comments Download
M src/ports/SkFontConfigInterface_android.cpp View 3 chunks +0 lines, -152 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/AndroidPaintTest.cpp View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
djsollen
6 years, 4 months ago (2014-07-31 15:45:20 UTC) #1
bungeman-skia
So long as Clank and Android all keep running, lgtm.
6 years, 4 months ago (2014-07-31 16:13:25 UTC) #2
djsollen
6 years, 4 months ago (2014-07-31 16:20:32 UTC) #3
reed1
lgtm
6 years, 4 months ago (2014-08-05 14:50:40 UTC) #4
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 4 months ago (2014-08-06 13:31:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/434623002/1
6 years, 4 months ago (2014-08-06 13:32:07 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-06 13:43:08 UTC) #7
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 4 months ago (2014-08-06 13:46:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/434623002/20001
6 years, 4 months ago (2014-08-06 13:47:11 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 13:58:13 UTC) #10
Message was sent while issue was closed. 
Change committed as 1b27704eba15be4e9d1997faac42038493a30be5

Powered by Google App Engine
This is Rietveld 408576698