Prevent repeated taps from resetting insertion handle position

content/browser/renderer_host/input/touch_selection_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/touch_selection_controller.h"
 
 #include "base/logging.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 
 namespace content {
@@ skipping 129 matching lines @@
     end_selection_handle_->SetVisible(GetEndVisible(), animation_style);
   }
   if (is_insertion_active_)
     insertion_handle_->SetVisible(GetStartVisible(), animation_style);
 }
 
 void TouchSelectionController::OnSelectionEditable(bool editable) {
   if (selection_editable_ == editable)
     return;
   selection_editable_ = editable;
-  ResetCachedValues();
+  if (!is_insertion_active_ && !is_selection_active_)
+    ResetCachedValues();
   if (!selection_editable_)
     DeactivateInsertion();
 }
 
 void TouchSelectionController::OnSelectionEmpty(bool empty) {
   if (selection_empty_ == empty)
     return;
   selection_empty_ = empty;
-  ResetCachedValues();
+  if (!is_insertion_active_ && !is_selection_active_)

[jdduke (slow), 2014/07/31 12:04:45]

Hmm, maybe rename to ResetCachedValuesIfInactive and do the check there? That's
probably what we want in all cases where this method is called.  Also please add
a unit test.

+    ResetCachedValues();
 }
 
 bool TouchSelectionController::Animate(base::TimeTicks frame_time) {
   if (is_insertion_active_)
     return insertion_handle_->Animate(frame_time);
 
   if (is_selection_active_) {
     bool needs_animate = start_selection_handle_->Animate(frame_time);
     needs_animate |= end_selection_handle_->Animate(frame_time);
     return needs_animate;
@@ skipping 192 matching lines @@
 }
 
 TouchHandle::AnimationStyle TouchSelectionController::GetAnimationStyle(
     bool was_active) const {
   return was_active && client_->SupportsAnimation()
              ? TouchHandle::ANIMATION_SMOOTH
              : TouchHandle::ANIMATION_NONE;
 }
 
 }  // namespace content