extensions/browser/DEPS - Issue 434493002: OAuth2 support for Webstore downloads.

Side by Side Diff: extensions/browser/DEPS

Issue 434493002: OAuth2 support for Webstore downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/updater/extension_downloader.cc ('K') | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | extensions/browser/OWNERS » ('j') | extensions/browser/webstore_oauth2_token_provider.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/keyed_service",	2 "+components/keyed_service",

3 "+components/pref_registry",	3 "+components/pref_registry",

4 "+content/public/browser",	4 "+content/public/browser",

	5 "+google_apis/gaia",
	asargent_no_longer_on_chrome 2014/08/06 00:26:29 are you sure we want to take a dependency on this, are you sure we want to take a dependency on this, instead of defining some abstract interface that gets wired up inside chrome/browser/extensions/ ? Ken Rockot(use gerrit already) 2014/08/06 16:49:55 Even if I abstract away this dependency now, a tim Show quoted text On 2014/08/06 00:26:29, Antony Sargent wrote: > are you sure we want to take a dependency on this, instead of defining some > abstract interface that gets wired up inside chrome/browser/extensions/ ? Even if I abstract away this dependency now, a time will soon come when we want device identity support in app_shell, and that's going to end up depending on gaia as well. So there's going to be a gaia-dependent component shared between //extensions/shell and //chrome. It could live in its own //components component, or maybe in a new //google_apis/webstore, but it will still depend on gaia. Alternatively, I don't see why OAuth2TokenService and/or IdentityProvider themselves couldn't be abstracted away from google_apis into something more generic like //components/oauth2. Then I would feel less bad about duplicating specific google_apis dependencies within each extensions embedder rather than in general-purpose extensions code. +rogerta as OWNER of //google_apis/gaia - Any thoughts on this? asargent_no_longer_on_chrome 2014/08/06 19:38:47 BTW I'm not strongly opposed to the way you have i Show quoted text On 2014/08/06 16:49:55, Ken Rockot wrote: > On 2014/08/06 00:26:29, Antony Sargent wrote: > > are you sure we want to take a dependency on this, instead of defining some > > abstract interface that gets wired up inside chrome/browser/extensions/ ? > > Even if I abstract away this dependency now, a time will soon come when we want > device identity support in app_shell, and that's going to end up depending on > gaia as well. So there's going to be a gaia-dependent component shared between > //extensions/shell and //chrome. It could live in its own //components > component, or maybe in a new //google_apis/webstore, but it will still depend on > gaia. > > Alternatively, I don't see why OAuth2TokenService and/or IdentityProvider > themselves couldn't be abstracted away from google_apis into something more > generic like //components/oauth2. Then I would feel less bad about duplicating > specific google_apis dependencies within each extensions embedder rather than in > general-purpose extensions code. > > +rogerta as OWNER of //google_apis/gaia - Any thoughts on this? BTW I'm not strongly opposed to the way you have it or anything - I just wanted to make sure we thought it through before moving forward.
5 "+grit/extensions_strings.h",	6 "+grit/extensions_strings.h",

6 "+net",	7 "+net",

7 "+skia/ext/image_operations.h",	8 "+skia/ext/image_operations.h",

8 "+sync",	9 "+sync",

9 "+third_party/leveldatabase",	10 "+third_party/leveldatabase",

10 "+third_party/skia/include",	11 "+third_party/skia/include",

11 "+webkit/browser/fileapi",	12 "+webkit/browser/fileapi",

12 ]	13 ]

OLD	NEW