content/test/data/service_worker/imports_bust_memcache.html - Issue 434453005: test for https://codereview.chromium.org/419693002/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/service_worker/imports_bust_memcache.html

Issue 434453005: test for https://codereview.chromium.org/419693002/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/test/data/service_worker/empty_script.js ('K') | « content/test/data/service_worker/empty_script.js ('k') | content/test/data/service_worker/worker_with_one_import.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 // See ServiceWorkerBrowserTest ImportsBustMemcache.

	4 // Content-shell data persists, so unreg first to clear old data.
	dominicc (has gone to gerrit) 2014/08/04 01:27:10 Content-shell -> Content Shell unreg - avoid abbre Content-shell -> Content Shell unreg - avoid abbreviations.
	5 // Register, unregister, then reregister, the browsertest .cc code examines
	dominicc (has gone to gerrit) 2014/08/04 01:27:10 then/the seems odd then/the seems odd
	6 // the state of the scriptcache to ensure the script and import are cached.

	7

	8 var scope = 'imports_bust_memcache_scope/*';

	9 var script = 'worker_with_one_import.js';

	10

	11 navigator.serviceWorker.unregister(scope)

	12 .then(function(value) {

	13 console.log('initial unregistration done');

	14 return navigator.serviceWorker.register(script, {scope: scope});

	15 })

	16 .then(function(worker) {

	17 console.log('initial registration done');

	18 return navigator.serviceWorker.unregister(scope);

	19 })

	20 .then(function(value) {

	21 console.log('unregistration done');

	22 return navigator.serviceWorker.register(script, {scope: scope});

	23 })

	24 .then(function(worker) {
	dominicc (has gone to gerrit) 2014/08/04 01:27:10 This will become a registration object. Since it i This will become a registration object. Since it is not used you might name it _ to avoid the need to update it. Ditto above.
	25 console.log('second registration done');

	26 document.title = 'OK'; // Titlewatcher looks for this.

	27 })

	28 .catch(function(e) {

	29 console.log('error will robinson!');
	dominicc (has gone to gerrit) 2014/08/04 01:27:10 I think Will Robinson was warned of danger, not er I think Will Robinson was warned of danger, not errors; maybe omit this. Since the test failure by setting the title to FAILED will point to this place, the log probably doesn't help with debugging the test. michaeln 2014/08/08 02:32:37 levity removed Show quoted text On 2014/08/04 01:27:10, dominicc wrote: > I think Will Robinson was warned of danger, not errors; maybe omit this. Since > the test failure by setting the title to FAILED will point to this place, the > log probably doesn't help with debugging the test. levity removed
	30 document.title = 'FAILED';

	31 });

	32 </script>

OLD	NEW