Chromium Code Reviews Chromium Code Reviews
Issue 434453002:
Promote inlines to first-class invalidation citizens (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) | 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) |
| 3 * (C) 1999 Antti Koivisto (koivisto@kde.org) | 3 * (C) 1999 Antti Koivisto (koivisto@kde.org) |
| 4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved. | 4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved. |
| 5 * Copyright (C) 2010, 2012 Google Inc. All rights reserved. | 5 * Copyright (C) 2010, 2012 Google Inc. All rights reserved. |
| 6 * | 6 * |
| 7 * This library is free software; you can redistribute it and/or | 7 * This library is free software; you can redistribute it and/or |
| 8 * modify it under the terms of the GNU Library General Public | 8 * modify it under the terms of the GNU Library General Public |
| 9 * License as published by the Free Software Foundation; either | 9 * License as published by the Free Software Foundation; either |
| 10 * version 2 of the License, or (at your option) any later version. | 10 * version 2 of the License, or (at your option) any later version. |
| (...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 59 | 59 |
| 60 virtual LayerType layerTypeRequired() const = 0; | 60 virtual LayerType layerTypeRequired() const = 0; |
| 61 | 61 |
| 62 // Returns true if the background is painted opaque in the given rect. | 62 // Returns true if the background is painted opaque in the given rect. |
| 63 // The query rect is given in local coordinate system. | 63 // The query rect is given in local coordinate system. |
| 64 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const { re turn false; } | 64 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const { re turn false; } |
| 65 | 65 |
| 66 // This is null for anonymous renderers. | 66 // This is null for anonymous renderers. |
| 67 ContainerNode* node() const { return toContainerNode(RenderObject::node()); } | 67 ContainerNode* node() const { return toContainerNode(RenderObject::node()); } |
| 68 | 68 |
| 69 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) OVERRIDE; | |
|
Julien - ping for review
2014/08/04 19:36:39
Shouldn't this be private as we assume we call Ren
leviw_travelin_and_unemployed
2014/08/05 22:34:44
Done.
| |
| 69 protected: | 70 protected: |
| 70 void createLayer(LayerType); | 71 void createLayer(LayerType); |
| 71 | 72 |
| 72 virtual void willBeDestroyed() OVERRIDE; | 73 virtual void willBeDestroyed() OVERRIDE; |
| 73 | 74 |
| 74 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer*, co nst LayoutPoint&, const LayoutRect&) const OVERRIDE; | 75 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer*, co nst LayoutPoint&, const LayoutRect&) const OVERRIDE; |
| 75 | 76 |
| 77 virtual void invalidatePaintIfNeeded(const PaintInvalidationState&, const Re nderLayerModelObject& newPaintInvalidationContainer); | |
| 76 private: | 78 private: |
| 77 virtual bool isLayerModelObject() const OVERRIDE FINAL { return true; } | 79 virtual bool isLayerModelObject() const OVERRIDE FINAL { return true; } |
| 78 | 80 |
| 79 OwnPtr<RenderLayer> m_layer; | 81 OwnPtr<RenderLayer> m_layer; |
| 80 | 82 |
| 81 // Used to store state between styleWillChange and styleDidChange | 83 // Used to store state between styleWillChange and styleDidChange |
| 82 static bool s_wasFloating; | 84 static bool s_wasFloating; |
| 83 }; | 85 }; |
| 84 | 86 |
| 85 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderLayerModelObject, isLayerModelObject()); | 87 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderLayerModelObject, isLayerModelObject()); |
| 86 | 88 |
| 87 } // namespace blink | 89 } // namespace blink |
| 88 | 90 |
| 89 #endif // RenderLayerModelObject_h | 91 #endif // RenderLayerModelObject_h |
| OLD | NEW |
