Issue 434443003: Merge PageMeasurement to PageTest.

Issue 434443003: Merge PageMeasurement to PageTest. (Closed)

Created:
6 years, 4 months ago by chrishenry

Modified:
6 years, 4 months ago

Reviewers:
ariblue, nednguyen

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge PageMeasurement to PageTest, move MeasurementFailure to page_test.py. Fixed all files that refer to MeasurementFailure in this patch. Rest of subclasses of PageMeasurement will be fixed in a follow up patch. BUG=383635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287703

Patch Set 1 : #

Total comments: 3

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -101 lines)			Patch
M	tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/chrome_proxy/integration_tests/network_metrics.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/perf/measurements/rasterize_and_record_micro.py	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tools/perf/measurements/repaint.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/perf/measurements/skpicture_printer.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/perf/measurements/smoothness_controller.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_measurement.py	View	2 chunks	+1 line, -64 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_measurement_unittest.py	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_test.py	View	2 chunks	+77 lines, -3 lines	3 comments	Download
M	tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/434443003/40001

6 years, 4 months ago (2014-08-05 22:24:09 UTC) #3

ariblue

https://codereview.chromium.org/434443003/diff/40001/tools/telemetry/telemetry/page/page_test.py File tools/telemetry/telemetry/page/page_test.py (right): https://codereview.chromium.org/434443003/diff/40001/tools/telemetry/telemetry/page/page_test.py#newcode296 tools/telemetry/telemetry/page/page_test.py:296: """ The MeasurePage function from PageMeasurement raised the NotImplementedError() ...

6 years, 4 months ago (2014-08-05 23:36:19 UTC) #4

chrishenry

https://codereview.chromium.org/434443003/diff/40001/tools/telemetry/telemetry/page/page_test.py File tools/telemetry/telemetry/page/page_test.py (right): https://codereview.chromium.org/434443003/diff/40001/tools/telemetry/telemetry/page/page_test.py#newcode296 tools/telemetry/telemetry/page/page_test.py:296: """ On 2014/08/05 23:36:19, ariblue wrote: > The MeasurePage ...

6 years, 4 months ago (2014-08-05 23:45:46 UTC) #5

ariblue

https://codereview.chromium.org/434443003/diff/40001/tools/telemetry/telemetry/page/page_test.py File tools/telemetry/telemetry/page/page_test.py (right): https://codereview.chromium.org/434443003/diff/40001/tools/telemetry/telemetry/page/page_test.py#newcode296 tools/telemetry/telemetry/page/page_test.py:296: """ On 2014/08/05 23:45:46, chrishenry wrote: > On 2014/08/05 ...

6 years, 4 months ago (2014-08-05 23:54:57 UTC) #6

Message was sent while issue was closed.

Change committed as 287703

Expand Messages | Collapse Messages