Issue 434423002: Add dependencies on gtest and gmock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434423002: Add dependencies on gtest and gmock (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer, Michael Achenbach

CC:
v8-dev, tfarina

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Add dependencies on gtest and gmock Because Benedikt said so. BUG=none LOG=y R=bmeurer@chromium.org, machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22806

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+236 lines, -0 lines)			Patch
M	.DEPS.git	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	.gitignore	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	DEPS	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Makefile	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	testing/gmock.gyp	View	1 chunk	+62 lines, -0 lines	0 comments	Download
A	testing/gtest.gyp	View	1 chunk	+158 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

jochen (gone - plz use gerrit)

Committed patchset #1 manually as 22806 (presubmit successful).

6 years, 4 months ago (2014-08-04 09:11:10 UTC) #3

Message was sent while issue was closed.

Nice to see v8 migrating to gtest :)