Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 434403003: [DevTools] Add user metric action DeviceModeEnabled. (Closed)

Created:
6 years, 4 months ago by dgozman
Modified:
6 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Add user metric action DeviceModeEnabled. BUG=399362 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M LayoutTests/inspector/user-metrics-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/host/UserMetrics.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
dgozman
Take a look please.
6 years, 4 months ago (2014-08-04 07:11:59 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-04 12:18:33 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-05 07:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/434403003/1
6 years, 4 months ago (2014-08-05 07:55:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-05 13:26:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 14:39:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20937)
6 years, 4 months ago (2014-08-05 14:39:02 UTC) #7
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-05 15:14:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/434403003/1
6 years, 4 months ago (2014-08-05 15:16:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-05 17:12:02 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 22:47:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/19747)
6 years, 4 months ago (2014-08-05 22:47:39 UTC) #12
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-06 07:37:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/434403003/1
6 years, 4 months ago (2014-08-06 07:37:36 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 07:48:51 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 08:46:11 UTC) #16
Message was sent while issue was closed. 
Change committed as 179583

Powered by Google App Engine
This is Rietveld 408576698