Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 434393003: Use tighter typing in editing: VisiblePosition & VisibleSelection (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, zoltan1
Project:
blink
Visibility:
Public.

Description

Use tighter typing in editing: VisiblePosition & VisibleSelection Use tighter typing in editing/ to increase code readability. This CL focuses on VisiblePosition and VisibleSelection. R=yosin@chromium.org, leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179527

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -57 lines) Patch
M Source/core/dom/Position.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/PositionIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 5 chunks +12 lines, -13 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 9 chunks +15 lines, -15 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (0 generated)
Inactive
6 years, 4 months ago (2014-08-04 17:34:43 UTC) #1
leviw_travelin_and_unemployed
Sure. LGTM.
6 years, 4 months ago (2014-08-04 18:31:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/434393003/1
6 years, 4 months ago (2014-08-04 18:32:21 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-04 19:29:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 20:14:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20602)
6 years, 4 months ago (2014-08-04 20:14:28 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-04 21:18:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/434393003/1
6 years, 4 months ago (2014-08-04 21:19:23 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-04 21:56:13 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 22:34:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20647)
6 years, 4 months ago (2014-08-04 22:34:34 UTC) #11
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-04 23:30:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/434393003/1
6 years, 4 months ago (2014-08-04 23:31:35 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 00:14:17 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 00:53:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20686)
6 years, 4 months ago (2014-08-05 00:54:00 UTC) #16
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-05 13:04:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/434393003/1
6 years, 4 months ago (2014-08-05 13:07:50 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 14:38:51 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 16:09:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20968)
6 years, 4 months ago (2014-08-05 16:09:44 UTC) #21
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-05 19:07:47 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/434393003/1
6 years, 4 months ago (2014-08-05 19:11:34 UTC) #23
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 21:12:05 UTC) #24
Message was sent while issue was closed. 
Change committed as 179527

Powered by Google App Engine
This is Rietveld 408576698