Issue 434343006: Merge 283929 "Fix canPlayType() support for non-RFC compliant mp..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434343006: Merge 283929 "Fix canPlayType() support for non-RFC compliant mp..." (Closed)

Created:
6 years, 4 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 4 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src/

Visibility:
Public.

More Reviews

Description

Merge 283929 "Fix canPlayType() support for non-RFC compliant mp..." > Fix canPlayType() support for non-RFC compliant mp3 mimetype. > > The 'audio/mpeg; codecs="mp3"' mimetype is not RFC 3003 compliant, but a > bunch of sites apparently use it. This change restores the behavior that > was in M35 and earlier and returns "probably" for this mimetype. > > The changes are intentionally kept small so they can be easily be merged > to the M36 & M37 branches. > > BUG=393720, 386073 > TEST=MediaCanPlayTypeTest.CodecSupportTest_mp3 > > Review URL: https://codereview.chromium.org/400023002 TBR=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287335

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
	M	content/browser/media/media_canplaytype_browsertest.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	net/base/mime_util.cc	View		2 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

6 years, 4 months ago (2014-08-04 15:19:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r287335.

Expand Messages | Collapse Messages