Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 434253002: Only build EasyUnlockService when extensions are enabled. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Only build EasyUnlockService when extensions are enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-02 17:31:21 UTC) #1
xiyuan
LGTM Totally forget ENABLE_EXTENSIONS. Thanks for fixing.
6 years, 4 months ago (2014-08-03 00:40:30 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-03 02:39:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/434253002/1
6 years, 4 months ago (2014-08-03 02:39:34 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-03 05:49:02 UTC) #5
Message was sent while issue was closed.
Change committed as 287248

Powered by Google App Engine
This is Rietveld 408576698