build/android/pylib/content_settings.py - Issue 434193002: [Android] Parallelize provision_devices.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/content_settings.py

Issue 434193002: [Android] Parallelize provision_devices.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/content_settings.py

diff --git a/build/android/pylib/content_settings.py b/build/android/pylib/content_settings.py

index 6993eb375324d1e78ada1887862209cb9eafc85d..d2220537202f9dc0186adb2503426de5e1186af8 100644

--- a/build/android/pylib/content_settings.py

+++ b/build/android/pylib/content_settings.py

@@ -50,7 +50,10 @@ class ContentSettings(dict):

key = v

elif k == 'value':

value = v

- assert key, value

+ if not key:

tonyg 2014/08/15 17:19:43 ditto, given the lack of tests, I'd recommend a se

jbudorick 2014/08/15 17:41:47 This one seems unlikely to cause more flakes -- an

+ continue

+ if not value:

+ value = ''

yield key, value

def __getitem__(self, key):