Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 434183002: Don't fail component registration if the component on disk is corrupt. (Closed)

Created:
6 years, 4 months ago by waffles
Modified:
6 years, 4 months ago
Reviewers:
Sorin Jianu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't fail component registration if the component on disk is corrupt. BUG=399806 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287636

Patch Set 1 #

Patch Set 2 : switch the happy case to be first #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/component_updater/default_component_installer.cc View 1 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
waffles
Hello Sorin, please take a look at this small CL to improve DefaultComponentInstaller's behavior when ...
6 years, 4 months ago (2014-08-01 22:58:47 UTC) #1
Sorin Jianu
lgtm Thank you!
6 years, 4 months ago (2014-08-01 23:25:21 UTC) #2
waffles
The CQ bit was checked by waffles@chromium.org
6 years, 4 months ago (2014-08-05 20:39:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/waffles@chromium.org/434183002/20001
6 years, 4 months ago (2014-08-05 20:41:52 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 23:18:56 UTC) #5
Message was sent while issue was closed. 
Change committed as 287636

Powered by Google App Engine
This is Rietveld 408576698