Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 434163002: Changes to module_integrity_verifier.cc that allow the function VerifyModule (Closed)

Created:
6 years, 4 months ago by krstnmnlsn
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@patchHunting2
Project:
chromium
Visibility:
Public.

Description

On greg's suggestion, incorporated this change into https://codereview.chromium.org/406043003/ ============================================================ Changes to module_integrity_verifier.cc that allow the function VerifyModule to return a list of functions that may have been modified (in addition to whether or not the module is modified). BUG=

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -97 lines) Patch
M chrome/browser/safe_browsing/module_integrity_verifier.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/module_integrity_verifier.cc View 7 chunks +150 lines, -60 lines 0 comments Download
M chrome/browser/safe_browsing/module_integrity_verifier_unittest.cc View 3 chunks +49 lines, -32 lines 0 comments Download
M chrome/browser/safe_browsing/verifier_test/verifier_test_dll.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/verifier_test/verifier_test_dll.def View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
krstnmnlsn
6pm on a friday is when you're supposed to send out cls right... Here's the ...
6 years, 4 months ago (2014-08-01 22:02:17 UTC) #1
grt (UTC plus 2)
6 years, 4 months ago (2014-08-01 23:28:33 UTC) #2
On 2014/08/01 22:02:17, krstnmnlsn wrote:
> 6pm on a friday is when you're supposed to send out cls right... 
> Here's the modified-function reporting stuff.  I have spent far too much time
> rearranging/refactoring this, so I figured I would get some input on it before
I
> went any farther with that.  Also this doesn't include the latest changes from
> the first branch (https://codereview.chromium.org/406043003/) yet.
> 
> One thing is that I would really like to pull out chunks of what VerifyModule
> does into helpers, but all the helpers I've tried would need too many
> inputs/outputs to be worth it.  I could add even more fields to the state
object
> I've got there (ModuleVerificationState - name open to suggestions) and have
> less parameters that way, thoughts?
> 
> Ignore the (almost non-existent) tests for now :)

Is this an evolution of the work in issue 406043003 that is meant to follow it,
or to replace it? If the latter, could you make this a new patch set in that
issue? If yes, try something like "git cl issue 406043003" and "git br -u
origin/master" so that you can upload this change into the other rietveld issue.

Powered by Google App Engine
This is Rietveld 408576698