Source/bindings/scripts/utilities.py - Issue 434133002: Support WebIDL's ExtendedAttributeIdentList in the Blink parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/utilities.py

Issue 434133002: Support WebIDL's ExtendedAttributeIdentList in the Blink parser (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/utilities.py

diff --git a/Source/bindings/scripts/utilities.py b/Source/bindings/scripts/utilities.py

index 28beb17c94e8a842c10f7f4ddafa980f47ef0224..367476598a1b8e0b115f749d41ce258941e91d78 100644

--- a/Source/bindings/scripts/utilities.py

+++ b/Source/bindings/scripts/utilities.py

@@ -153,10 +153,10 @@ def get_interface_extended_attributes_from_idl(file_contents):

extended_attributes_string = match.group(1)

extended_attributes = {}

- # FIXME: this splitting is WRONG: it fails on ExtendedAttributeArgList like

- # 'NamedConstructor=Foo(a, b)'

+ # FIXME: this splitting is WRONG: it fails on extended attributes where lists of

+ # multiple values are used, which are seperated by a comma and a space.

parts = [extended_attribute.strip()

- for extended_attribute in extended_attributes_string.split(',')

+ for extended_attribute in re.split(',\s+', extended_attributes_string)

# Discard empty parts, which may exist due to trailing comma

if extended_attribute.strip()]

for part in parts:

« no previous file with comments | « Source/bindings/scripts/idl_validator.py ('k') | Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »