Add ARM64 SIMD support to libjpeg_turbo

Add ARM64 SIMD support to libjpeg_turbo

Cherry-picked r1108, r1109, r1333, r1375, r1386, r1389 and r1390,
which add ARM64 SIMD support to libjpeg_turbo. These changes only
affect ARM64 platforms (no change to other platforms or files).

BUG=356100
R=noel@chromium.org

Committed: 291725

[rmcilroy, 2014-08-01 15:21:24]

Noel, could you take a look please.  This shouldn't affect any architecture
other than arm64.  Thanks.

[Noel Gordon, 2014-08-04 06:09:32]

You should update google.patch as noted in the README.chromium.

https://codereview.chromium.org/434123003/diff/1/libjpeg.gyp
File libjpeg.gyp (right):

https://codereview.chromium.org/434123003/diff/1/libjpeg.gyp#newcode249
libjpeg.gyp:249: [ 'OS=="linux" or OS=="freebsd" or (OS=="android" and
target_arch!="arm")', {
Do we need a target_arch!="arm64" around here?

[rmcilroy, 2014-08-04 16:03:30]

> You should update google.patch as noted in the README.chromium.

Done.

https://codereview.chromium.org/434123003/diff/1/libjpeg.gyp
File libjpeg.gyp (right):

https://codereview.chromium.org/434123003/diff/1/libjpeg.gyp#newcode249
libjpeg.gyp:249: [ 'OS=="linux" or OS=="freebsd" or (OS=="android" and
target_arch!="arm")', {
On 2014/08/04 06:09:32, Noel Gordon wrote:
> Do we need a target_arch!="arm64" around here?

Having looked at this, I'm pretty sure yasm is only used for ia32 and x64 so
rather than adding "arm64" and "mips", I think the condition should instead be
(OS=="android" and (target_arch=='ia32' or target_arch=='x64').  This also
involved a change in the "assemble" rule below.

[rmcilroy, 2014-08-04 18:29:34]

On 2014/08/04 16:03:30, rmcilroy wrote:
> > You should update google.patch as noted in the README.chromium.
> 
> Done.
> 
> https://codereview.chromium.org/434123003/diff/1/libjpeg.gyp
> File libjpeg.gyp (right):
> 
> https://codereview.chromium.org/434123003/diff/1/libjpeg.gyp#newcode249
> libjpeg.gyp:249: [ 'OS=="linux" or OS=="freebsd" or (OS=="android" and
> target_arch!="arm")', {
> On 2014/08/04 06:09:32, Noel Gordon wrote:
> > Do we need a target_arch!="arm64" around here?
> 
> Having looked at this, I'm pretty sure yasm is only used for ia32 and x64 so
> rather than adding "arm64" and "mips", I think the condition should instead be
> (OS=="android" and (target_arch=='ia32' or target_arch=='x64').  This also
> involved a change in the "assemble" rule below.

I'll drop this change until we resolve the issue I reported on crbug.com/356100.
 Thanks for the reviews Noel.

[rmcilroy, 2014-08-29 11:05:53]

Noel, I've updated the CL to include the fixes (which have already landed
upstream in libjpeg_turbo).  I am going to be OOO for 2 weeks from tonight, so I
would really like to land this this evening if at all possible?  Thanks.

[Noel Gordon, 2014-08-29 12:04:13]

lgtm - you've verified these changes fix the issues we were seeing in the bug,
let's continue.

[Noel Gordon, 2014-08-29 12:21:29]

And if the arm4 bots are running layout tests, please watch those while landing.

[rmcilroy, 2014-08-29 12:32:02]

On 2014/08/29 12:21:29, Noel Gordon wrote:
> And if the arm4 bots are running layout tests, please watch those while
landing.

There are no arm64 bots running layout tests just yet.  Thanks Noel!

[rmcilroy, 2014-08-29 12:32:23]

Committed patchset #3 (id:40001) manually as 291725 (presubmit successful).