Issue 434115: Revert "Apply test isolation goodness to net_unittests."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434115: Revert "Apply test isolation goodness to net_unittests." (Closed)

Created:
11 years ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert "Apply test isolation goodness to net_unittests." Revert "Fix a memory leak in DnsReloadTimer" Valgrind test_shell_tests still fails, will investigate offline. :( TBR=wtc BUG=12710 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33205

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -16 lines)			Patch
M	net/base/host_resolver_proc.cc	View	2 chunks	+6 lines, -11 lines	0 comments	Download
M	net/base/run_all_unittests.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/ocsp/nss_ocsp.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.  Too bad!

Expand Messages | Collapse Messages