Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 434113002: Split trace messages into chunks based on size, not event count (Closed)

Created:
6 years, 4 months ago by caseq
Modified:
6 years, 4 months ago
Reviewers:
yurys
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

Split trace messages into chunk based on size, not event count base::StringPrintf() fails quietly for strings larger than 32M, so we could send and empty message to the DevTools front-end, Let's split trace event notifications into chunks based on the chunk size rather than the event count as we used to do. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/devtools/devtools_tracing_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
lgtm
6 years, 4 months ago (2014-08-01 13:34:03 UTC) #1
caseq
6 years, 4 months ago (2014-08-01 13:34:32 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 4 months ago (2014-08-01 13:38:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/434113002/1
6 years, 4 months ago (2014-08-01 13:41:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 19:38:35 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 05:53:51 UTC) #6
Message was sent while issue was closed.
Change committed as 287157

Powered by Google App Engine
This is Rietveld 408576698