Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 434109: Don't save popup blocker whitelist modifications performed while off the reco... (Closed)

Created:
11 years ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Don't save popup blocker whitelist modifications performed while off the record. BUG=none TEST=Go incognito, visit popuptest.com, whitelist popups, restart and verify they're not whitelisted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33315

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -13 lines) Patch
M chrome/browser/blocked_popup_container.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/blocked_popup_container.cc View 1 2 4 chunks +25 lines, -12 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years ago (2009-11-26 02:20:36 UTC) #1
Elliot Glaysher
11 years ago (2009-11-30 17:39:13 UTC) #2
LGTM with nit:

http://codereview.chromium.org/434109/diff/3002/3003
File chrome/browser/blocked_popup_container.cc (right):

http://codereview.chromium.org/434109/diff/3002/3003#newcode414
chrome/browser/blocked_popup_container.cc:414: prefs_ = NULL;  // Don't persist
any zoom levels.
I assume this comment was copy/pasted?

Powered by Google App Engine
This is Rietveld 408576698