Issue 434109: Don't save popup blocker whitelist modifications performed while off the reco...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434109: Don't save popup blocker whitelist modifications performed while off the reco... (Closed)

Created:
11 years ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't save popup blocker whitelist modifications performed while off the record. BUG=none TEST=Go incognito, visit popuptest.com, whitelist popups, restart and verify they're not whitelisted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33315

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -13 lines)			Patch
	M	chrome/browser/blocked_popup_container.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/blocked_popup_container.cc	View	1 2	4 chunks	+25 lines, -12 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years ago (2009-11-30 17:39:13 UTC) #2

LGTM with nit:

http://codereview.chromium.org/434109/diff/3002/3003
File chrome/browser/blocked_popup_container.cc (right):

http://codereview.chromium.org/434109/diff/3002/3003#newcode414
chrome/browser/blocked_popup_container.cc:414: prefs_ = NULL;  // Don't persist
any zoom levels.
I assume this comment was copy/pasted?

Expand Messages | Collapse Messages