Issue 434103003: Fix StringFileWriter::Seek()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434103003: Fix StringFileWriter::Seek() (Closed)

Created:
6 years, 4 months ago by Mark Mentovai

Modified:
6 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Fix StringFileWriter::Seek(). The final range check needs to check that the value fits in a size_t, because that’s what StringFileWriter uses for its offset_. TEST=util_test StringFileWriter.SeekInvalid R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6e720f14214d

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	util/file/string_file_writer.cc	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

6 years, 4 months ago (2014-08-01 17:30:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 6e720f14214d (presubmit successful).