This fixes an issue where view source on a local file would return a...

This fixes an issue where view source on a local file would return a
blank page.

This bug was introduced by the fix for issue 26129 (r30418), which
was to limit view source so that it wouldn't be able to load
javascript or data URLs, but that change forgot to allow file urls.

This fixes the above omission by allowing file URLs again.

TEST=works:view-source:file:///tmp/test.html, doesn't work:view-source:javascript:alert('foo')
BUG=27409
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33380

[amit, 2009-11-26 00:12:49]

lgtm

On Wed, Nov 25, 2009 at 1:56 PM,  <gspencer@chromium.org> wrote:
> Reviewers: amit,
>
> Description:
> This fixes an issue where view source on a local file would return a
> blank page.
>
> This bug was introduced by the fix for issue 26129 (r30418), which
> was to limit view source so that it wouldn't be able to load
> javascript or data URLs, but that change forgot to allow file urls.
>
> This fixes the above omission by allowing file URLs again.
>
> TEST=works:view-source:file:///tmp/test.html, doesn't
> work:view-source:javascript:alert('foo')
> BUG=27409
>
> Please review this at http://codereview.chromium.org/434094
>
> SVN Base: http://src.chromium.org/svn/trunk/src/
>
> Affected files:
>  M     chrome/browser/browser_url_handler.cc
>
>
> Index: chrome/browser/browser_url_handler.cc
> ===================================================================
> --- chrome/browser/browser_url_handler.cc       (revision 32889)
> +++ chrome/browser/browser_url_handler.cc       (working copy)
> @@ -22,7 +22,7 @@
>     // other kind of 'active' url scheme like 'javascript' or 'data'.
>     static const char* const allowed_sub_schemes[] = {
>       chrome::kHttpScheme, chrome::kHttpsScheme, chrome::kFtpScheme,
> -      chrome::kChromeUIScheme
> +      chrome::kChromeUIScheme, chrome::kFileScheme
>     };
>
>     bool is_sub_scheme_allowed = false;
>
>
>