Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 434083003: Remove the dependency of Extension API from tts_chromeos (Closed)

Created:
6 years, 4 months ago by mrunal
Modified:
6 years, 4 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the dependency of Extension API from tts_chromeos Moving the extension api dependency from TtsPlatformImplChromeOs to TtsExtensionEngine through TtsEngineDelegate. This is part of an effort to move TTS to content. BUG=347045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287160

Patch Set 1 #

Patch Set 2 : Fix compilation error on ChromeOS #

Total comments: 2

Patch Set 3 : Fix the nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -21 lines) Patch
M chrome/browser/speech/extension_api/tts_engine_extension_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/speech/tts_chromeos.cc View 1 2 chunks +9 lines, -21 lines 0 comments Download
M chrome/browser/speech/tts_controller.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/speech/tts_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/speech/tts_controller_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mrunal
The above failures doesn't seem to be related to my patch. If you think they ...
6 years, 4 months ago (2014-08-01 15:37:34 UTC) #1
dmazzoni
lgtm I agree, the failures look unrelated. https://codereview.chromium.org/434083003/diff/20001/chrome/browser/speech/tts_controller.h File chrome/browser/speech/tts_controller.h (right): https://codereview.chromium.org/434083003/diff/20001/chrome/browser/speech/tts_controller.h#newcode102 chrome/browser/speech/tts_controller.h:102: // Load ...
6 years, 4 months ago (2014-08-01 17:14:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/434083003/20001
6 years, 4 months ago (2014-08-01 17:15:26 UTC) #3
mrunal
https://codereview.chromium.org/434083003/diff/20001/chrome/browser/speech/tts_controller.h File chrome/browser/speech/tts_controller.h (right): https://codereview.chromium.org/434083003/diff/20001/chrome/browser/speech/tts_controller.h#newcode102 chrome/browser/speech/tts_controller.h:102: // Load the build-in component extension for ChromeOS On ...
6 years, 4 months ago (2014-08-01 18:35:31 UTC) #4
dmazzoni
On Fri, Aug 1, 2014 at 11:35 AM, <mrunal.kapade@intel.com> wrote: > Acknowledged. Can I upload ...
6 years, 4 months ago (2014-08-01 21:38:15 UTC) #5
mrunal
On 2014/08/01 21:38:15, dmazzoni wrote: > On Fri, Aug 1, 2014 at 11:35 AM, <mailto:mrunal.kapade@intel.com> ...
6 years, 4 months ago (2014-08-01 22:07:01 UTC) #6
mrunal
The CQ bit was checked by mrunal.kapade@intel.com
6 years, 4 months ago (2014-08-01 22:11:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/434083003/40001
6 years, 4 months ago (2014-08-01 22:13:02 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 05:56:03 UTC) #9
Message was sent while issue was closed.
Change committed as 287160

Powered by Google App Engine
This is Rietveld 408576698