Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webkit/glue/plugins/plugin_lib_linux.cc

Issue 434071: Merge 33052 - Linux: Do not unload the o3d plugin in the browser process. Thi... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/249/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/plugin_lib_linux.cc
===================================================================
--- webkit/glue/plugins/plugin_lib_linux.cc (revision 33053)
+++ webkit/glue/plugins/plugin_lib_linux.cc (working copy)
@@ -59,6 +59,12 @@
return false;
}
+// TODO(thestig) This is a hack to work around the crash in bug 25245. Remove
+// this once we read plugins out of process.
+bool SkipPluginUnloadHack(const WebPluginInfo& info) {
+ std::string filename = info.path.BaseName().value();
+ return (filename.find("npo3dautoplugin") != std::string::npos); // O3D
+}
} // anonymous namespace
namespace NPAPI {
@@ -108,7 +114,8 @@
info->desc = UTF8ToWide(description);
}
- base::UnloadNativeLibrary(dl);
+ if (!SkipPluginUnloadHack(*info))
+ base::UnloadNativeLibrary(dl);
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698