Issue 434050: Remove the temporary instrumentation added to track down a crash in URLFetche...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434050: Remove the temporary instrumentation added to track down a crash in URLFetche... (Closed)

Created:
11 years, 1 month ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove the temporary instrumentation added to track down a crash in URLFetcher. This is almost a full revert of r31526, except that the two DCHECK(url_request_context_getter_) which I promoted to CHECK()s remain as CHECK()s (since they will be useful to catch similar problems in the future, and are cheap). BUG=27074 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33026

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	chrome/browser/net/url_fetcher.cc	View		4 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages