Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8389)

Unified Diff: chrome/browser/cocoa/extensions/browser_actions_controller.mm

Issue 434047: o Updates the browser action buttons when a tab is changed. This is needed fo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/extensions/browser_actions_controller.mm
===================================================================
--- chrome/browser/cocoa/extensions/browser_actions_controller.mm (revision 32947)
+++ chrome/browser/cocoa/extensions/browser_actions_controller.mm (working copy)
@@ -214,8 +214,11 @@
return;
std::string tooltip = extension_->browser_action()->GetTitle(tabId);
- if (!tooltip.empty())
+ if (tooltip.empty()) {
+ [self setToolTip:nil];
+ } else {
[self setToolTip:base::SysUTF8ToNSString(tooltip)];
+ }
SkBitmap image = extension_->browser_action()->GetIcon(tabId);
if (!image.isNull()) {
@@ -318,6 +321,12 @@
return self;
}
+- (void)update {
+ for (BrowserActionButton* button in [buttons_ allValues]) {
+ [button updateState];
+ }
+}
+
- (void)hidePopup {
[popupController_ close];
popupController_ = nil;
« no previous file with comments | « chrome/browser/cocoa/extensions/browser_actions_controller.h ('k') | chrome/browser/cocoa/toolbar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698