Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/bisect-perf-regression.py

Issue 434043002: Refactor bisect-perf-regression_test.py and add smoke test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/bisect-perf-regression_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index b1aa1309c4033696f6608bd1b1f5ee10227d1c1c..bbdb6422e27290d585ab35b6d155c01cafffcf44 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -286,6 +286,8 @@ def ConfidenceScore(good_results_lists, bad_results_lists):
# Flatten the lists of results lists.
sample1 = sum(good_results_lists, [])
sample2 = sum(bad_results_lists, [])
+ if not sample1 or not sample2:
+ return 0.0
# The p-value is approximately the probability of obtaining the given set
# of good and bad values just by chance.
@@ -3054,6 +3056,12 @@ class BisectPerformanceMetrics(object):
last_broken_revision = None
last_broken_revision_index = -1
+ culprit_revisions = []
+ other_regressions = []
+ regression_size = 0.0
+ regression_std_err = 0.0
+ confidence = 0.0
+
for i in xrange(len(revision_data_sorted)):
k, v = revision_data_sorted[i]
if v['passed'] == 1:
« no previous file with comments | « no previous file | tools/bisect-perf-regression_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698