Issue 434026: disable extension toolstrips by default, adding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434026: disable extension toolstrips by default, adding (Closed)

Created:
11 years, 1 month ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, Jói

Visibility:
Public.

Description

disable extension toolstrips by default, adding --enable-extension-toolstrips BUG=24475 TEST=Extension*Toolstrip*

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix a failing test #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
M	chrome/browser/extensions/extension_browsertest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

11 years, 1 month ago (2009-11-23 22:42:03 UTC) #2

lgtm, thanks for doing thi.

http://codereview.chromium.org/434026/diff/1/5
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/434026/diff/1/5#newcode924
chrome/common/extensions/extension.cc:924: switches::kEnableExtensionToolstrips)
&&
Nit: this line should be indented more.

Expand Messages | Collapse Messages