Enable the RTL UI support in the extensions_ui (chrome://extensions). While d...

Enable the RTL UI support in the extensions_ui (chrome://extensions). While doing so, make it use the font-family and font-size (84% by default) set in locale_settings for the current UI language. The body font size used to be 87%. To make up for the difference between two, the font sizes given in percentage are adjusted (increased) accordingly in the rest of the file.


BUG=28202
TEST=1. Run Chrome with '--lang=he' or '--lang=ar' on Windows (or 'LANGUAGE=he chrome' / 'LANGUAGE=ar chrome' on Linux) and go to 'chrome://extensions'. Strings are not yet translated, but the overall UI should be RTL.
2. Run Chrome in en-US (or your favorite LTR language) and go to 'chrome://extensions'. It should look the same as before.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33108

[rafaelw, 2009-11-24 19:41:24]

lgtm

[rafaelw, 2009-11-24 20:40:42]

Sorry, Jungshik. I decided to apply patch locally to inspect the visual changes.

Two nits:

1) It looks like the "Developer" header is now slightly too big.

2) The pack-extension dialog appears to have two problems:
  -The header for the dialog (which, in english, reads "PackExtension") is
running against the side of the panel
  -The blue margin on the left and right of the panel are two big.

I created this HTML panel, so I can help with (2) if you'd like.

[jungshik at Google, 2009-11-25 00:53:18]

Rafael,

Can you take a look again? I addressed your concerns. I kept scratching my head
with Arabic because Hebrew was all right. It turned out that 'Pack Extension
heading' is too short in Arabic to fill the hardcoded-width of 500px. I worked
around the problem by increasing the font size for the html dialog to 13px for
dir='rtl' (that way, Arabic heading would get long enough to fill the 500px
width). I can go up to 14px (which looks even better in Arabic although it's a
little too large in Hebrew). 




On 2009/11/24 20:40:42, rafaelw wrote:
> Sorry, Jungshik. I decided to apply patch locally to inspect the visual
changes.
> 
> Two nits:
> 
> 1) It looks like the "Developer" header is now slightly too big.
> 
> 2) The pack-extension dialog appears to have two problems:
>   -The header for the dialog (which, in english, reads "PackExtension") is
> running against the side of the panel
>   -The blue margin on the left and right of the panel are two big.
> 
> I created this HTML panel, so I can help with (2) if you'd like.

[rafaelw, 2009-11-25 19:34:43]

lgtm. for reals this time =-).

This is really nice work. Thanks!